Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

manual paths for p2p and operator keys #54

Merged
merged 1 commit into from
Mar 5, 2025
Merged

manual paths for p2p and operator keys #54

merged 1 commit into from
Mar 5, 2025

Conversation

Zk2u
Copy link
Contributor

@Zk2u Zk2u commented Mar 5, 2025

Description

This provides a fix for STR-1148 where the secret service wasn't using hardened paths due to some upstream issues in strata-key-derivation by hardcoding the paths.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added (where necessary) tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@Zk2u Zk2u added the bug Something isn't working label Mar 5, 2025
@Zk2u Zk2u requested a review from storopoli March 5, 2025 19:19
@Zk2u Zk2u self-assigned this Mar 5, 2025
storopoli
storopoli approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK ca2712a

@storopoli storopoli enabled auto-merge March 5, 2025 19:21
@storopoli storopoli added this pull request to the merge queue Mar 5, 2025
@codecov Codecov
Copy link

codecov bot commented Mar 5, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.62%. Comparing base (4392f29) to head (ca2712a).
Report is 1 commits behind head on main.

@@            Coverage Diff             @@
##             main      #54      +/-   ##
==========================================
+ Coverage   68.60%   68.62%   +0.01%     
==========================================
  Files         120      120              
  Lines       17680    17687       +7     
==========================================
+ Hits        12130    12137       +7     
  Misses       5550     5550
Files with missing lines Coverage Δ
bin/secret-service/src/seeded_impl/mod.rs 47.72% <100.00%> (ø)
bin/secret-service/src/seeded_impl/operator.rs 100.00% <100.00%> (ø)
bin/secret-service/src/seeded_impl/p2p.rs 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Merged via the queue into main with commit a6df1bf Mar 5, 2025
12 checks passed
@storopoli storopoli deleted the STR-1148-Secret-Service-define-hardened-paths-for-the-P2P-and-Operator-s-Wallet-keys branch March 5, 2025 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@storopoli storopoli storopoli approved these changes

Assignees

@Zk2u Zk2u

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Zk2u @storopoli